Fix return value from dba_pdo::q()

According to the documentation, this function should never return null.
Still that's what it did if a non-select query raised a PDOException.
This patch fixes this, so that it so that the function conforms to the
docs.
This commit is contained in:
Harald Eilertsen
2025-01-12 21:43:48 +01:00
parent 3e6a646603
commit 4625ffa6b4

View File

@@ -73,7 +73,7 @@ class dba_pdo extends dba_driver {
}
}
$result = null;
$result = false;
$this->error = '';
$select = stripos($sql, 'select') === 0 || stripos($sql, 'returning ') > 0;
@@ -162,10 +162,6 @@ class dba_pdo extends dba_driver {
db_logger('dba_pdo: PDOStatement returned, did not expect that.');
return false;
}
} elseif ($res === null) {
// While `q` should never return null, that's exactly what it
// does when the insert fails. Let's turn it to a false instead.
$res = false;
}
if (is_array($res)) {