The email template used for verifying the email on new account
registration is wrong in several translations, including British
English.
Clicking any of the links in the emails produced results in a blank page
with no information or helpful error to the poor person trying to
register with a hub.
This patch updates the translated templates to correspond to the (US)
English main template. Translators should revisit the templates to
translate the english texts to the corresponding templates language
where necessary.
Issue........: https://framagit.org/hubzilla/core/-/work_items/1989
Existing function account_allow() does not seem to be used a whole
lot, and certainly not when approving a registration request.
Created new function send_reg_confirmation_email_from_register
(going for longest-function-name-in-Hubzilla) which attempts to
send such a confirmation email, and also a new email template.
Plugged this into the create_account_from_register function.
Open question: Should the sending of this email be among the success
criteria for the create_account_from_register function?
Since there is no easy way to produce direct links to approve/reject
registrations, create new email template which simply links to the
Accounts admin page.
In response to comments:
- Add type annotations
- Simplify some 'if' statements
- add and fix some whitespace
- simplify input arguments to the function
