The NULL_DATE constant is defined conditionally in the DBA static class.
This causes issues with static analyzing tools like PHPStan, because
they can not really know if the constant is defined or not.
We could make PHPStan ignore this, but since there already is a
`get_null_date()` method on the `dba_driver` class, this patch
changes the code to use this method instead.
We could also use the public static attribute `$null_date` on the DBA
class directly, but using a method feels cleaner, and allows for making
the attribute private, or even removing it completely at some later
time.
I'm not removing the NULL_DATE constant for now, in case it is in use by
any extensions.
There's no reason we should format the data into a string in the
Perfstats module. Let the recipient do what they want with it instead.
As an example, we reduce the precision of the loadavg stats in the
system status widget. 3 digits precision should be more than enough for
this type of status display.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
The total number of queries is not that interesting for performance
measurements, so let's do queries pr/second instead. Adds a timestamp
column to the dataset, which could be useful for other purposes as well
(like making a graph over time etc.)
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
Make some stricter rules for accessing the perfstats module. We only
want to respond to GET request for json data made by a site admin.
This means we also need to pass along the credentials in the request.
Didn't immediately figure out how to do that using `z_fetch_url`, so we
just fall back to using the JavaScript to populate the widget. This
makes it idle for about 5 sec before it gets the first data sample.
I think that's probably OK.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
Adds a bit of javascript that requests the performance stats every 5
seconds.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
Moves collecting performance statistics for the system status activity
widget to a separate module. This will make it easier to get the data
from JavaScript or external monitoring tools.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
Since there is no easy way to produce direct links to approve/reject
registrations, create new email template which simply links to the
Accounts admin page.
In response to comments:
- Add type annotations
- Simplify some 'if' statements
- add and fix some whitespace
- simplify input arguments to the function
Current send_reg_approval_email function expects account to already
exist, and does not seem to be called anywhere. New function takes
necessary information from the register table.
Added call to new function in Regate.php after verification is
done. Will fail and roll back if the function call fails or if no
admin accounts were found to notify (delivered<1).
