Make `Route::set()` private. It is not referenced outside of the class
itself, and is also unsafe as it uncritically replaces the system routes
with whatever value it was passed.
The remaining functions are set to public visibility.
If the query towards the hubloc table don't return any entries, the loop
would continue without modifying any of the variables that could
possibly make the loop end.
Renaming the translation template to *.pot, works better with some
tooling like poedit and lokalize.
Project......: Improve Superblock Addon
Sponsored-by.: NLnet NGI0 Commons Fund
Some tests will need to load their own database fixtures. By making this
API public we make it easy for them to do so.
This change is needed by the tests for the Superblock addon.
Project......: Improve Superblock Addon
Sponsored-by.: NLnet NGI0 Commons Fund
The NULL_DATE constant is defined conditionally in the DBA static class.
This causes issues with static analyzing tools like PHPStan, because
they can not really know if the constant is defined or not.
We could make PHPStan ignore this, but since there already is a
`get_null_date()` method on the `dba_driver` class, this patch
changes the code to use this method instead.
We could also use the public static attribute `$null_date` on the DBA
class directly, but using a method feels cleaner, and allows for making
the attribute private, or even removing it completely at some later
time.
I'm not removing the NULL_DATE constant for now, in case it is in use by
any extensions.
Fetch the initial data when the widget loads, and then update every five
sec after that. Also better indication of uninitialized values.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
There's no reason we should format the data into a string in the
Perfstats module. Let the recipient do what they want with it instead.
As an example, we reduce the precision of the loadavg stats in the
system status widget. 3 digits precision should be more than enough for
this type of status display.
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
The total number of queries is not that interesting for performance
measurements, so let's do queries pr/second instead. Adds a timestamp
column to the dataset, which could be useful for other purposes as well
(like making a graph over time etc.)
Project......: Performance Profiling
Sponsored-by.: NLnet NGI0 Commons Fund
